[Bug 1227334] Review Request: libgudev - GObject-based wrapper library for libudev

Wed Jun 3 20:53:07 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1227334

Michele Baldessari <michele at acksyn.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |michele at acksyn.org
           Assignee|nobody at fedoraproject.org    |michele at acksyn.org
              Flags|                            |fedora-review+

--- Comment #1 from Michele Baldessari <michele at acksyn.org> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
     generated". 4 files have unknown license. Detailed output of
     licensecheck in /home/michele/Fedora/Packages/libgudev/review-
     libgudev/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gtk-doc, /usr/share
     /gtk-doc/html, /usr/lib64/girepository-1.0, /usr/share/gir-1.0
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gtk-
     doc/html/gudev(libgudev1-devel),
     /usr/include/gudev-1.0/gudev(libgudev1-devel),
     /usr/include/gudev-1.0(libgudev1-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: libgudev-230-1.fc22.x86_64.rpm
          libgudev-devel-230-1.fc22.x86_64.rpm
          libgudev-230-1.fc22.src.rpm
libgudev.x86_64: W: spelling-error Summary(en_US) GObject -> G Object, Object
libgudev.x86_64: W: spelling-error Summary(en_US) libudev -> Libreville
libgudev.x86_64: W: spelling-error %description -l en_US libudev -> Libreville
libgudev-devel.x86_64: W: only-non-binary-in-usr-lib
libgudev.src: W: spelling-error Summary(en_US) GObject -> G Object, Object
libgudev.src: W: spelling-error Summary(en_US) libudev -> Libreville
libgudev.src: W: spelling-error %description -l en_US libudev -> Libreville
3 packages and 0 specfiles checked; 0 errors, 7 warnings.

Rpmlint (debuginfo)
-------------------
Checking: libgudev-debuginfo-230-1.fc22.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
----------------------------
libgudev.x86_64: W: spelling-error Summary(en_US) GObject -> G Object, Object
libgudev.x86_64: W: spelling-error Summary(en_US) libudev -> Libreville
libgudev.x86_64: W: spelling-error %description -l en_US libudev -> Libreville
libgudev.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgudev-1.0.so.0.2.0 /lib64/libgio-2.0.so.0
libgudev.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgudev-1.0.so.0.2.0 /lib64/libpthread.so.0
libgudev-devel.x86_64: W: only-non-binary-in-usr-lib
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

Requires
--------
libgudev (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    rtld(GNU_HASH)

libgudev-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libgudev(x86-64)
    libgudev-1.0.so.0()(64bit)
    pkgconfig(glib-2.0)
    pkgconfig(gobject-2.0)

Provides
--------
libgudev:
    libgudev
    libgudev(x86-64)
    libgudev-1.0.so.0()(64bit)
    libgudev1

libgudev-devel:
    libgudev-devel
    libgudev-devel(x86-64)
    libgudev1-devel
    pkgconfig(gudev-1.0)

Source checksums
----------------
https://download.gnome.org/sources/libgudev/230/libgudev-230.tar.xz :
  CHECKSUM(SHA256) this package     :
a2e77faced0c66d7498403adefcc0707105e03db71a2b2abd620025b86347c18
  CHECKSUM(SHA256) upstream package :
a2e77faced0c66d7498403adefcc0707105e03db71a2b2abd620025b86347c18

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -n libgudev
Buildroot used: fedora-22-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Notes:
- Not a biggie for now. I assume this will be fixed in later systemd versions 
  by removing that file or adding an obsolete:
    file /usr/lib/debug/usr/lib64/libgudev-1.0.so.0.2.0.debug from install
 of libgudev-debuginfo-230-1.fc22.x86_64 conflicts with file from package syst
emd-debuginfo-219-5.fc22.x86_64

- Might want to do s/remote/remove/ in the comment in the spec file ;)

ACK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component