[Bug 1230874] Review Request: felix-scr-maven-plugin - Maven plugin for generating OSGi Declarative Services annotations

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 12 13:38:03 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1230874



--- Comment #9 from Severin Gehwolf <sgehwolf at redhat.com> ---
%global source maven-scr-plugin

Please call this "artifactId" or some such. "source" seems too generic and is
very confusing when working with RPMs since a source is generally some tarball
or a config file or...


# For building from source tarball
Source0:       
http://www.apache.org/dist/felix/%{source}-%{version}-source-release.tar.gz

Please drop this "For building from source tarball" comment. It doesn't really
make sense. Everything is built from source.

Looks good otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list