[Bug 1231318] Review Request: php-zordius-lightncandy - An extremely fast PHP implementation of handlebars and mustache

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1231318



--- Comment #7 from Michael Cronenworth <mike at cchtml.com> ---
(In reply to Remi Collet from comment #6)
> [!]: Requires correct, justified where necessary.
>   see phpcompatinfo report, Missing
>   Requires: php-pcre php-spl php-reflection

Please explain why these are Requires. The php(language) requires draws in the
same packages. Do I need 3 duplicate Requires entries? If so, where is this in
the Packaging Guidelines?

> [!]: Package complies to the Packaging Guidelines
>   Please used normalized github URL
>   https://fedoraproject.org/wiki/Packaging:SourceURL#Github

Except that this project produces a release tarball. The Source URL is OK.

> [?]: Package does not generate any conflict.
>   While /usr/share/php/lightncandy is fine for now (and seems ok with curent
> Guildelines)
>   /usr/share/php/zordius-lightncandy or /usr/share/php/zordius/lightncandy
> seems better
>   (this single class is not PSR-0 compliant...)

I'm willing to change the directory structure to whatever is more appropriate.
Pending other changes I will use /usr/share/php/zordius/lightncandy.

>   An autoload is "perhaps" not required for a single class.. but this can
> change in
>   the future (other classes, dependency), so could have some value.

This stuff (speaking in general here) is not declared in the Packaging
Guidelines and I had no idea that loaders were available outside of composer.

1. Please get composer in Fedora.
2. Please change the PHP Packaging Guidelines.
3. If there is documentation I have not seen, please share it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component