[Bug 1225134] Review Request: composer - Dependency Manager for PHP

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1225134

Shawn Iwinski <shawn.iwinski at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #13 from Shawn Iwinski <shawn.iwinski at gmail.com> ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL5 bits after initial import.



The phpcompatinfo regular requires seem to be a mix of build requires and
regular requires while the build requires seem very sparse.  Also, the regular
requires is missing php-dom.  I'll let you choose the details there though.



No blockers.



===== APPROVED =====

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component