[Bug 1228172] Review Request: jedis - A redis Java client

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1228172



--- Comment #3 from gil cattaneo <puntogil at libero.it> ---
(In reply to Hans de Goede from comment #2)
> Hi,
> 
> I'm afraid that (after building and installing the package from bug 1228169)
> it does not build for me:
> 
> [ERROR] Exit code: 1 -
> /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/jedis
> 
> <snip>
> 
> [ERROR]
> /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/
> jedis/BinaryJedis.java:326: error: malformed HTML
> [ERROR] * @see
> <ahref="http://code.google.com/p/redis/wiki/ExpireCommand">ExpireCommand</a>
> [ERROR] ^
> [ERROR]
> /home/hans/rpmbuild/BUILD/jedis-jedis-2.7.2/src/main/java/redis/clients/
> jedis/BinaryJedis.java:326: error: bad use of '>'
> 
> And a few more of these (and also lots of javadoc warnings), I've had build
> failures of several of my own java packages during the F-23 rebuild, these
> are caused by javadoc in the F-23/rawhide jdk being stricter.
for a maven build you should remove maven-javadoc-plugin from POM file/s
for a ant build you should add:
e.g.
               version="true"
               use="true"
               windowtitle="Classycle"
-              failonerror="true"/>
+              failonerror="true">
+      <arg value="-Xdoclint:none"/>
+    </javadoc>
or
e.g.
     <javadoc destdir="${javadoc.dir}" source="1.6" failonerror="true"
       access="protected" 
+      additionalparam="-Xdoclint:none"
       windowtitle="JGraphT : a free Java graph library"
       overview="${src.dir}/overview.html">
       <classpath refid="build.classpath" />

> I've managed to reproduce this issue on F-22 by installing the latest
> openjdk from F-23 on F-22:
> http://koji.fedoraproject.org/koji/buildinfo?buildID=651231
FiXED, remove maven-javadoc-plugin to use default javadoc setting to override
doclint issues

> This works fine on F-22 and gives you the stricter javadoc, which should
> allow you to reproduce and then fix this problem.
> 
> Also I've a question about the .spec file:
> 
> # take too much time and use web connection
> %mvn_build -f
> 
> Can you make the comment better so that it explains things a bit more, also
> use a web connection? I know maven normally does that, but I thought that
> %mvn_build disables that ?
The test suite require unavailable resources, especially if the builder is a
ARM arch based.
These builders are pretty slow compared to other arch.
Moreover, we don't have JIT enabled on this architecture, so everything
runs in interpreted mode. Package builds can be one to three orders of
magnitude slower on armv7hl compared to x86_64 and often fail due to
timeouts or OutOfMemoryError.
For "real" builds the only known workaround is
resubmitting the build until you get non-ARM builder.
Is a waste of time and resources.
> Regards,
> 
> Hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component