[Bug 1229610] Review Request: doxy2man - Create man pages from doxygen XML output
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jun 26 02:07:04 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1229610
Jeff Backus <jeff.backus at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Jeff Backus <jeff.backus at gmail.com> ---
(In reply to Nikos Mavrogiannopoulos from comment #4)
> (In reply to Jeff Backus from comment #3)
> > Thanks for addressing all of the issues I raised. Package looks good, though
> > I do have one last request: please update to the latest version since it
> > does contain a license file.
>
> Done. Thanks.
>
> http://people.redhat.com/nmavrogi/fedora/doxy2man.spec
> http://people.redhat.com/nmavrogi/fedora/doxy2man-0-1.20150625git.fc22.src.
> rpm
Looks good! Package PASSES.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 2 files have unknown license. Detailed
output of licensecheck in /mnt/storage/homes/jeff/tmp/reviews/doxy2man
/review-doxy2man/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: doxy2man-0-1.20150625git.fc22.i686.rpm
doxy2man-0-1.20150625git.fc22.src.rpm
doxy2man.i686: W: spelling-error Summary(en_US) doxygen -> oxygen, d oxygen
doxy2man.i686: W: spelling-error %description -l en_US doxygen -> oxygen, d
oxygen
doxy2man.src: W: spelling-error Summary(en_US) doxygen -> oxygen, d oxygen
doxy2man.src: W: spelling-error %description -l en_US doxygen -> oxygen, d
oxygen
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (debuginfo)
-------------------
Checking: doxy2man-debuginfo-0-1.20150625git.fc22.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
doxy2man.i686: W: spelling-error Summary(en_US) doxygen -> oxygen, d oxygen
doxy2man.i686: W: spelling-error %description -l en_US doxygen -> oxygen, d
oxygen
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Requires
--------
doxy2man (rpmlib, GLIBC filtered):
libGL.so.1
libQt5Core.so.5
libQt5Gui.so.5
libQt5Network.so.5
libQt5Xml.so.5
libQt5XmlPatterns.so.5
libc.so.6
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libm.so.6
libpthread.so.0
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
rtld(GNU_HASH)
Provides
--------
doxy2man:
doxy2man
doxy2man(x86-32)
Source checksums
----------------
https://github.com/gsauthof/doxy2man/archive/4d6a7dfd3e53f3edc2508c078c309eccd44cc8f3/4d6a7dfd3e53f3edc2508c078c309eccd44cc8f3.tar.gz#/doxy2man-4d6a7dfd3e53f3edc2508c078c309eccd44cc8f3.tar.gz
:
CHECKSUM(SHA256) this package :
391162087d385a8795389d70ae342ad5bc158701691087cdfa68b556ab15ae5d
CHECKSUM(SHA256) upstream package :
391162087d385a8795389d70ae342ad5bc158701691087cdfa68b556ab15ae5d
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -n doxy2man
Buildroot used: fedora-22-i386
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list