[Bug 1196289] Review Request: nodejs-defaults - Merge single level defaults over a config object

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1196289



--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk> ---
> Summary:        A simple one level options merge utility

This is a pretty bad summary; there's no way a user would be able to tell if 
they need this or not. It's also not an utility, its a library.

> Group:          Development/Languages/Other

No souch group exist. Please drop the tag altogether or pick a suitable
library from /usr/share/doc/rpm/GROUPS

> BuildRoot:      %{_tmppath}/%{pkg_name}-%{version}-build

Not needed anymore unless you're building for el5.

> ExclusiveArch:  %{ix86} x86_64 %{arm} noarch

You can use %{nodejs_arches}, unless you're building for el5.

> #%{nodejs_find_provides_and_requires}

This doesn't look right, is that intentional? Note that macro expansion happens 
before parsing comments.

> %description
> Merge single level defaults over a config object.

This needs improvement, it seems to make very little sense.

> %prep
> %setup -q -n package
> %build

Please keep spacing consistent (add a line break before %build).

> %defattr(-,root,root,-)

Not needed for post-el5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component