[Bug 1195279] Review Request: preupgrade-assistant - Preupgrade assistant a tool for assess system before an upgrade

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1195279



--- Comment #21 from Petr Hracek <phracek at redhat.com> ---
Spec URL: https://phracek.fedorapeople.org/preupgrade-assistant.spec
SRPM URL:
https://phracek.fedorapeople.org/preupgrade-assistant-0.11.7-4.fc21.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #20)
> - Why BR:pykickstart R:pykickstart in F23?
> 
You are right python3-kickstart should require pykickstart in F23
> - Can you add %check back?
> 
Done
> - Why the extra directory level in
> %{_rpmconfigdir}/macros.d/macros.preupgrade-assistant/macros.preupgrade-
> assistant? I don't see other packages doing this.
> 
Typo
> - %preupgrade_build is defined to the old name /usr/bin/create_group_xml.
> 
Fixed
> - preupgrade-assistant.rpm has an empty /usr/share/doc/preupgrade directory
> and README files are in /usr/share/preupgrade.
> 
README is in /usr/share/doc/preupgrade directory.
README file should be in both directories. The file is copied to
/root/preupgrade/ directory after an assessment.
User can see after a upgrade/migration what results mean.
But I will corrected it after package review so that only one README file is
enough.

> - I installed the rpm on F21. /usr/bin/preupg fails with:
> Traceback (most recent call last):
>   File "/usr/bin/preupg", line 8, in <module>
>     from preup.application import Application
>   File "/usr/lib/python2.7/site-packages/preup/application.py", line 18, in
> <module>
>     from preuputils.compose import XCCDFCompose
> ImportError: No module named preuputils.compose
> 
> Installing also -devel subpackage fixes that. Maybe you should merge -devel
> back into the main package. They are both really tiny, so the split is
> probably not worth the trouble.
> 
Merged
> - Looking at the first message:
> The Preupgrade Assistant is a diagnostics tool 
> and does not perform the actual upgrade.
> Make sure you back up your system and all of your data now,
> before using the Upgrade Tool to avoid potential data loss.
> Do you want to continue? y/n
> 
> If it is only a diagnostic tool, why is it unsafe to run?
> Also, why does it require root privileges? Isn't the RPM database public?
We need to have a access to all files and directories. Root access is really
needed. Some data are accessible only under root account.
> 
> - In the man page: "All common log files are stored in
> /var/cache/preupgrade/common". Isn't /var/log/preupgrade used?
Those directories are different.
- /var/log/preupgrade directory is used for logs generated by
preupgrade-assistant itself as a program
- /var/cache/preupgrade/common directory contains special files used by
contents
> 
> - This package seems useless without preupgrade-assistant-contents. Is this
> available somewhere?

Draft for Packaging Guidelines is already finished
(https://fedoraproject.org/wiki/User:Phracek/Draft:Packaging:PreupgradeAssistant)
Currently now I would like to add it to
http://fedoraproject.org/wiki/Packaging:Guidelines#Application_Specific_Guidelines

I will send a mail to devel list which describes how to create a content for
preupgrade-assistant.

I will create several bugzilla's to specific components for creating contents.
Likie mariadb, postgresql, etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component