[Bug 1199693] Review Request: pcp-pmda-cpp - C++ library for PCP PMDAs

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1199693



--- Comment #5 from Paul Colby <redhat at colby.id.au> ---
Thanks Nathan,

I've fixed the _FORTIFY_SOURCE issues (you're right, they were related to
disabling optimisations for unit test coverage reports only) by updating the
build system to not touch optimisaton flags if _FORTIFY_SOURCE(!=0) is present.

I've also updated the build system to use Fedora's gtest library (Debian
refuses to provide that) instead of the external gtest project (which still
gets pulled in on Debian systems, or when gtest-devel is not installed), and so
prevents the build system needing svn - at least for Fedora, when gtest-devel
is installed (the spec file now requires gtest-devel, but otherwise would
require svn, and external network access).

I've just updated the *.spec and *.src.rpm files listed above (probably just
minutes after your fedora-review run).  fedora-review now builds cleanly for
me, but I can see the two issues you've noted in the generated review file.

Also, before building the *.src.rpm, I run rpmlint which is reporting:

pcp-pmda-cpp.spec:28 W: rpm-buildroot-usage %build %{__rm} -r %{buildroot}

So I'll look into that one too.

Thanks again :)

Paul.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component