[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1193175



--- Comment #2 from Török Edwin <edwin at skylable.com> ---
(In reply to Tom "spot" Callaway from comment #1)
> Check and resolve the few TODO items and I'll approve this package and
> sponsor you.

Thanks a lot for reviewing the package!

> 
> == Review ==
> TODO items:

New SRPM:
http://vol-public.s3.indian.skylable.com:8008/fedorareview/skylable-sx-1.0-5.fc22.src.rpm
New koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=9212411

> 
> * Please make sure the systemd scripts work properly. This isn't a blocker,
> but I just didn't have the arrangement to test them out fully.

Works, tested on F22 Workstation Alpha, see below [1].

> * The -devel package has these files in it:
> /usr/lib64/sxclient/libsxf_aes256.so
> /usr/lib64/sxclient/libsxf_attribs.so
> /usr/lib64/sxclient/libsxf_undelete.so
> /usr/lib64/sxclient/libsxf_zcomp.so
> 
> I know sometimes the .so files in a subdir of %{_libdir} are not devel
> libraries, but rather, plugin libraries/modules that are needed for proper
> operation. Please confirm that these files should be in the -devel
> subpackage.

I confirm that the real plugins are in the -libs package, and they work even if
-devel is not installed, see [2]:
/usr/lib64/sxclient/libsxf_aes256-13.so
/usr/lib64/sxclient/libsxf_attribs-11.so
/usr/lib64/sxclient/libsxf_undelete-11.so
/usr/lib64/sxclient/libsxf_zcomp-10.so

> 
> * Spec says license is GPLv2, COPYING says it is "GPLv2 with exceptions and
> LGPLv2+ and BSD and MIT". Please correct the spec License field.

Updated the License field to:
main package and -client:
License: GPLv2 with exceptions and LGPLv2+ and BSD and MIT
-devel: License: LGPLv2+ with exceptions
-libs: License: LGPLv2+ with exceptions and MIT

> 
> Good:
> skylable-sx.x86_64: W: no-manual-page-for-binary sx.fcgi
> skylable-sx.x86_64: W: no-manual-page-for-binary sxserver
> skylable-sx.x86_64: W: no-manual-page-for-binary sxsetup
> skylable-sx.x86_64: W: no-manual-page-for-binary sxreport-server
> skylable-sx.x86_64: W: no-manual-page-for-binary sxadm
> skylable-sx-client.x86_64: W: no-manual-page-for-binary sxsim
> 
> Upstream should consider writing man pages for these binaries, but it is not
> a blocker for Fedora/EPEL.

We have this on our roadmap for version 1.1:
https://bugzilla.skylable.com/show_bug.cgi?id=1136

[1] How to test systemd units
# sxsetup
[...]
Enter the cluster name (use the same across all nodes) []: testme
[... accept defaults...]
# systemctl status sxserver sx-nginx
● sxserver.service - Scalable public and private cloud storage server
   Loaded: loaded (/usr/lib/systemd/system/sxserver.service; disabled; vendor
preset: disabled)
   Active: active (running) since Thu 2015-03-12 22:45:14 EET; 1min 25s ago
   [...]
● sx-nginx.service - The SX nginx HTTP server instance
   Loaded: loaded (/usr/lib/systemd/system/sx-nginx.service; disabled; vendor
preset: disabled)
   Active: active (running) since Thu 2015-03-12 22:45:15 EET; 1min 25s ago
   [...]
# systemctl stop sxserver
# systemctl status sxserver sx-nginx
● sxserver.service - Scalable public and private cloud storage server
   Loaded: loaded (/usr/lib/systemd/system/sxserver.service; disabled; vendor
preset: disabled)
   Active: inactive (dead)
    [...]
● sx-nginx.service - The SX nginx HTTP server instance
   Loaded: loaded (/usr/lib/systemd/system/sx-nginx.service; disabled; vendor
preset: disabled)
   Active: inactive (dead)
# systemctl start sxserver
# systemctl status sxserver sx-nginx
● sxserver.service - Scalable public and private cloud storage server
   Loaded: loaded (/usr/lib/systemd/system/sxserver.service; disabled; vendor
preset: disabled)
   Active: active (running) since Thu 2015-03-12 22:47:44 EET; 1s ago
   [...]
● sx-nginx.service - The SX nginx HTTP server instance
   Loaded: loaded (/usr/lib/systemd/system/sx-nginx.service; disabled; vendor
preset: disabled)
   Active: active (running) since Thu 2015-03-12 22:47:44 EET; 951ms ago

After a reboot the service is not running, however after running
'sudo systemctl enable sxserver' and rebooting it will (this should be
consistent with how sshd behaves).

[2] Testing plugins (filters)
# sudo sxvol filter
Name        Ver    Type        Short description
----        ---    ----        -----------------
attribs         1.1    generic        Preserve file attributes
aes256          1.4    crypt        Encrypt data using AES-256-CBC-HMAC-512
mode.
zcomp           1.0    compress    Compress files using zlib
undelete        1.1    generic        Backup removed files

# sxvol create -o admin -r 1 -f aes256 -s 10G sx://admin@testme/enc
[aes256]: Enter encryption password:
[aes256]: Re-enter encryption password:
Volume 'enc' (replica: 1, size: 10G, max-revisions: 1) created.
# sxcp /etc/redhat-release sx://admin@testme/enc/
Uploading /etc/redhat-release (size: 80B)
Transferred 4KB in <1s (@127.52KB/s)
# sxcp sx://admin@testme/enc/redhat-release .
Downloading redhat-release (size: 80B)
Transferred 4KB in <1s (@215.73KB/s)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component