[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Suggestions:
1) Group tag is optional in Fedora and is only needed if you want this package
to be built for EPEL5. See
http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag.
You can remove Group tag.

2) from https://pypi.python.org/pypi/oslo.context page, this module looks
compatible with python3 also. Therefore, add python3 subpackage.

3) Remove last unnecessary changelog entry

4) in %files
Following is wrong
%doc %{license}
This should be written as
%doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog
%license LICENSE

Then, using following lines you are installing files twice.
%{python2_sitelib}/
%{python2_sitelib}/oslo_context
Change this to just
%{python2_sitelib}/oslo_context

5) Add -doc subpackage like other python-oslo-* packages are providing in
Fedora. you can build documentation in %install using

pushd doc
sphinx-build -b html -d build/doctrees   source build/html
popd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component