[Bug 1203476] Review Request: sslh - Applicative protocol(SSL/SSH) multiplexer

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1203476



--- Comment #7 from Mukundan Ragavan <nonamedotc at gmail.com> ---
James, 

two (minor) comments regarding the submitted SPEC and SRPM


1) sslh.x86_64: W: file-not-utf8 /usr/share/doc/sslh/ChangeLog

This can be easily fixed.

http://fedoraproject.org/wiki/Common_Rpmlint_issues#file-not-utf8

2) 
cp %{name}-fork %{buildroot}%{_sbindir}/%{name}

(and subsequent lines)

It is important to preserve timestamps when installing files.

http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

Use,

cp -p {source} {destination}

Unfortunately, I cannot take this for review since I am not a sponsor. But,
good luck.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component