[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1142491



--- Comment #6 from František Dvořák <valtri at civ.zcu.cz> ---
(In reply to Mamoru TASAKA from comment #5)
> Some remarks:
> 
> * %license
>   - Use %license for LICENSE file
> 

Fixed.

> * Document files placement
>   - I would recommend to move README.md to main package
>     because it says "README" (not a blocker)
> 

OK. Some packagers place the README in the doc subpackage, but the main package
may be slightly better. :-)

> * License
>   - And while LICENSE file is MIT, actually lib/ox.rb seems
>     under BSD. Would you check this?

Fixed upstream (there were change of the license to MIT recently):

https://github.com/ohler55/ox/pull/108


New version:

Spec URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.8-2/rubygem-ox.spec
SRPM URL:
http://scientific.zcu.cz/fedora/rubygem-ox-2.1.8-2/rubygem-ox-2.1.8-2.fc23.src.rpm

%changelog
* Mon Mar 23 2015 František Dvořák <valtri at civ.zcu.cz> - 2.1.8-2
- Use the %%license tag
- Move README.md to main package

Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component