[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops

Tue Mar 24 21:54:14 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1198312

--- Comment #30 from T.C. Hollingsworth <tchollingsworth at gmail.com> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
=======

All blocking issues have been addressed!

TODO Post Review:
=================

- Work with upstream to resolve the issue with resizing in GNOME Shell.

- Work on enabling OpenCL CSC support if possible.

===== MUST items =====

C/C++:
[X]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL
     (v3 or later)", "BSD (2 clause)", "*No copyright* MIT/X11 (BSD like)".
     418 files have unknown license. Detailed output of licensecheck in
     /var/tmp/1198312-xpra/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
     contains desktop file(s) with a MimeType: entry.
     Note: desktop file(s) with MimeType entry in xpra
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
     contains icons.
     Note: icons in xpra
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 112640 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
     file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
     Note: Found : Packager: T.C. Hollingsworth <tchollingsworth at gmail.com>
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.

--> Tests are not run but likely do not work well in koji.

[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define _with_enc_x264 --without-
     enc_x264, %define _with_dec_avcodec --without-dec_avcodec, %define
     _with_csc_swscale --without-csc_swscale

--> I guess %define is required for --with(out) build conditionals?

[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.

Installation errors
-------------------
INFO: mock.py version 1.2.7 starting (python version = 2.7.5)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled yum cache
Start: cleaning yum metadata
Finish: cleaning yum metadata
INFO: enabled ccache
Mock Version: 1.2.7
INFO: Mock Version: 1.2.7
Finish: chroot init
INFO: installing package(s):
/var/tmp/1198312-xpra/results/xpra-0.14.21-3.fc22.x86_64.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/yum --installroot /var/lib/mock/fedora-22-x86_64/root/ --releasever
22 install /var/tmp/1198312-xpra/results/xpra-0.14.21-3.fc22.x86_64.rpm
--setopt=tsflags=nocontexts

--> This was due to missing js-web-socket-js.  It works fine locally.

Rpmlint
-------
Checking: xpra-0.14.21-3.fc22.x86_64.rpm
          xpra-0.14.21-3.fc22.src.rpm
xpra.x86_64: E: explicit-lib-dependency js-zlib
xpra.x86_64: W: dangling-relative-symlink
/usr/share/xpra/www/include/jquery.min.js
../../../javascript/jquery/2/jquery.min.js
xpra.x86_64: W: dangling-relative-symlink
/usr/share/xpra/www/include/inflate.min.js
../../../javascript/zlib/inflate.min.js
xpra.x86_64: W: dangling-relative-symlink
/usr/share/xpra/www/include/deflate.min.js
../../../javascript/zlib/deflate.min.js
xpra.x86_64: W: dangling-relative-symlink
/usr/share/xpra/www/include/web-socket-js ../../../javascript/web-socket-js
xpra.x86_64: W: no-manual-page-for-binary xpra_Xdummy
xpra.src:66: W: unversioned-explicit-provides bundled(js-zlib)
2 packages and 0 specfiles checked; 1 errors, 6 warnings.

--> Previously justified.

Requires
--------
xpra (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python
    PyOpenGL
    config(xpra)
    dbus-python
    gstreamer
    gstreamer-plugins-base
    gstreamer-plugins-good
    gstreamer-python
    js-jquery
    js-web-socket-js
    js-zlib
    libX11.so.6()(64bit)
    libXcomposite.so.1()(64bit)
    libXdamage.so.1()(64bit)
    libXext.so.6()(64bit)
    libXfixes.so.3()(64bit)
    libXrandr.so.2()(64bit)
    libXtst.so.6()(64bit)
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libvpx.so.1()(64bit)
    libwebp.so.5()(64bit)
    libxkbfile.so.1()(64bit)
    numpy
    pulseaudio
    pulseaudio-utils
    pygtkglext
    python(abi)
    python-imaging
    python-numeric
    python-rencode
    rtld(GNU_HASH)
    xorg-x11-drv-dummy
    xorg-x11-drv-void
    xorg-x11-server-Xvfb
    xorg-x11-server-utils

--> OK

Provides
--------
xpra:
    application()
    application(xpra.desktop)
    application(xpra_launcher.desktop)
    bundled(js-jquery-ui)
    config(xpra)
    mimehandler(text/x-xpraconfig)
    mimehandler(x-scheme-handler/xpra)
    xpra
    xpra(x86-64)

--> OK

Unversioned so-files
--------------------
xpra: /usr/lib64/python2.7/site-packages/xpra/codecs/argb/argb.so
xpra:
/usr/lib64/python2.7/site-packages/xpra/codecs/csc_cython/colorspace_converter.so
xpra: /usr/lib64/python2.7/site-packages/xpra/codecs/vpx/decoder.so
xpra: /usr/lib64/python2.7/site-packages/xpra/codecs/vpx/encoder.so
xpra: /usr/lib64/python2.7/site-packages/xpra/codecs/webp/decode.so
xpra: /usr/lib64/python2.7/site-packages/xpra/codecs/webp/encode.so
xpra: /usr/lib64/python2.7/site-packages/xpra/codecs/xor/cyxor.so
xpra: /usr/lib64/python2.7/site-packages/xpra/gtk_common/gdk_atoms.so
xpra: /usr/lib64/python2.7/site-packages/xpra/net/bencode/cython_bencode.so
xpra: /usr/lib64/python2.7/site-packages/xpra/server/stats/cymaths.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/bindings/core_bindings.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/bindings/display_source.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/bindings/keyboard_bindings.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/bindings/randr_bindings.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/bindings/wait_for_x_server.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/bindings/window_bindings.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/bindings/ximage.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/gtk_x11/gdk_bindings.so
xpra: /usr/lib64/python2.7/site-packages/xpra/x11/gtk_x11/gdk_display_source.so

--> All in %{python_sitearch} and excluded from autoprovides, OK.

Source checksums
----------------
https://xpra.org/src/xpra-0.14.21.tar.xz :
  CHECKSUM(SHA256) this package     :
1a802c3a6dc4b51c7a729d4cf8fb97c5a645d4f87428d7379e9009f3ff4f65f3
  CHECKSUM(SHA256) upstream package :
1a802c3a6dc4b51c7a729d4cf8fb97c5a645d4f87428d7379e9009f3ff4f65f3

--> OK

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -mfedora-22-x86_64 -b1198312
Buildroot used: fedora-22-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP,
Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component