[Bug 1206080] Review Request: antlr4 - Java parser generator

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1206080



--- Comment #5 from Mikolaj Izdebski <mizdebsk at redhat.com> ---
(In reply to Michael Simacek from comment #4)
> - Why the weird source URL?

This is a way of forcing different local file name of given source. rpmbuild
sees only the part after last "/" character (antlr4-4.5.tar.gz) while upstream
web server ignores the part after "#" character. Without that filename would be
just "4.5.tar.gz", which is ambiguous.

> - The prebuilt RPMS on Copr don't match the ones in SRPM
>   (not a problem, just FYI)

Fixed.

> - antlr4-4.5/runtime/Java/lib - there's a bundled jar, should be removed in
> prep

Fixed.

> - Minor detail - double colon in %jpackage_script classpath.
>   It does nothing, but it's confusing to the people who read the specfile

Fixed.

> [!]: Package contains no bundled libraries without FPC exception.

Bundled binaries used for bootstrapping have FPC exception. Are there any other
bundled libraries? Libraries bundled in SRPM but not used during build are
allowed.


Spec URL: http://mizdebsk.fedorapeople.org/review/antlr4/antlr4.spec
SRPM URL:
http://mizdebsk.fedorapeople.org/review/antlr4/antlr4-4.5-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component