[Bug 1203749] Review Request: dssp - Protein secondary structure assignment

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 30 14:48:51 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1203749



--- Comment #9 from Dave Love <d.love at liverpool.ac.uk> ---
Thanks for taking it.

I made makefile use DESTDIR in the usual way (not as above) by patching it.
Is this covered by policy somewhere?  It seems a waste of effort
to me, and I've made other things build in similar ways.

What's the problem with having -O3 in CFLAGS?  I assume it's known to be
beneficial, and
orion told me it was OK to use extra flags in that case.

I don't understand why BOOST_{INC,LIB}_DIR, DEBUG, and INSTALL need setting.

Using %licence gives:

Processing files: dssp-2.2.1-3.el6.x86_64
error: File must begin with "/": Boost
error: File must begin with "/": LICENSE_1_0.txt

SRPM URL: https://loveshack.fedorapeople.org/review/dssp-2.2.1-3.el6.src.rpm
Spec URL: https://loveshack.fedorapeople.org/review/dssp.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list