[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch at redhat.com



--- Comment #1 from Vít Ondruch <vondruch at redhat.com> ---
Just a few quick notes:

* Empty changelog
  - You should put some entry into changelog

* Unused BuildRequires
  - The following build requires are not required:

    BuildRequires: rubygem-rake, rubygem-rspec, rubygem-simplecov
    BuildRequires: ruby(release)
    BuildRequires: ruby

  - If you put the test suite into usable state, the  rubygem-rspec would be
the
    only required gem. Usage of Rake and SimpleCov is discouraged in every
case.

* Bundler is not required for runtime
  - I believe that "Requires: rubygem-bundler: is not needed, since
    rubygem-bundler is very likely pulled in via Vagrant dependency.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component