[Bug 1219540] Review Request: ahc-tools - Tools for RDO-manager automatic health checks

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1219540

Pranav Kant <pranav913 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pranav913 at gmail.com



--- Comment #2 from Pranav Kant <pranav913 at gmail.com> ---
A quick unofficial review:


* Sources used to build the package match the upstream source, as provided in
  the spec URL.
  Note: Upstream MD5sum check error, diff is in /home/fedora/1219540-ahc-
  tools/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL

* Source checksums
https://pypi.python.org/packages/source/a/ahc-tools/ahc-tools-0.1.0.tar.gz :
  CHECKSUM(SHA256) this package     :
f54f47164edf284a9d69b94150f31c2ddcf0e030093864372dc91aff549c7a6d
  CHECKSUM(SHA256) upstream package :
5a4e91ce671b8e3659a5fa90a394c9dcac2e20c5b51e3aaa58f630500a1598a0
diff -r also reports differences


Diff spec file in url and in SRPM
---------------------------------
--- /home/fedora/1219540-ahc-tools/srpm/ahc-tools.spec  2015-05-08
11:56:09.178829614 +0000
+++ /home/fedora/1219540-ahc-tools/srpm-unpacked/ahc-tools.spec 2015-05-07
14:15:29.000000000 +0000
@@ -4,11 +4,11 @@
 Name:           ahc-tools
 Summary:        Tools for RDO-manager automatic health checks
-Version:        0.1.0
-Release:        1%{?dist}
+Version: 0.1.0
+Release: 0.99.20150507.1415git%{?dist}
 License:        ASL 2.0
 Group:          System Environment/Base
 URL:            https://pypi.python.org/pypi/ahc-tools

-Source0:
https://pypi.python.org/packages/source/a/ahc-tools/ahc-tools-%{upstream_version}.tar.gz
+Source0: ahc-tools-0.1.0.tar.gz

 BuildArch:      noarch

* Package doesn't install properly.

* Empty README.rst


Rpmlint
-------
Checking: ahc-tools-0.1.0-0.99.20150507.1415git.fc21.noarch.rpm
          ahc-tools-0.1.0-0.99.20150507.1415git.fc21.src.rpm
ahc-tools.noarch: W: incoherent-version-in-changelog 0.1.0
['0.1.0-0.99.20150507.1415git.fc21', '0.1.0-0.99.20150507.1415git']
ahc-tools.noarch: E: zero-length /usr/share/doc/ahc-tools/README.rst
ahc-tools.noarch: W: no-manual-page-for-binary ahc-report
ahc-tools.noarch: W: no-manual-page-for-binary ahc-match
ahc-tools.src: W: invalid-url Source0: ahc-tools-0.1.0.tar.gz
2 packages and 0 specfiles checked; 1 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component