[Bug 1218089] Review Request: php-seld-cli-prompt - Allows you to prompt for user input on the command line

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1218089

Shawn Iwinski <shawn.iwinski at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Shawn Iwinski <shawn.iwinski at gmail.com> ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)

As usual, remove EPEL5 bits after initial import.



Since no %check, "BuildRequires:  php(language) >= 5.3" is not really necessary
unless you just want to prevent even building the RPM on systems without PHP >=
5.3.



No blockers.



===== APPROVED =====

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component