[Bug 1223623] Review Request: python-num2words - Modules to convert numbers to words

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1223623

Raphael Groner <projects.rg at smart.ms> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |projects.rg at smart.ms,
                   |                            |williamjmorenor at gmail.com
              Flags|                            |needinfo?(williamjmorenor at g
                   |                            |mail.com)



--- Comment #1 from Raphael Groner <projects.rg at smart.ms> ---
Some informal things to mention:

Do not add any license text by your own. Upstream provides it.
https://github.com/savoirfairelinux/num2words/blob/master/COPYING

Please remove:
Source1:        https://www.gnu.org/licenses/lgpl-2.1.txt
install -p -m 644 %{SOURCE1} \
%{_builddir}/%{pypi_name}-%{version}/LICENSE


> %exclude %{python2_sitelib}/tests/
Please patch setup.py file to not install tests at all, or remove it in
%install .


Does this work with Python3? If yes (and it seems so), you have to provide a
build also for Python3.
https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component