[Bug 1218025] Review Request: cashe - program and libraries for accessing a CAS cache
bugzilla at redhat.com
bugzilla at redhat.com
Wed May 27 16:05:10 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1218025
Pavel Odvody <podvody at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |james.antill at redhat.com
Flags| |needinfo?(james.antill at redh
| |at.com)
--- Comment #7 from Pavel Odvody <podvody at redhat.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Dist tag is present.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in /root/rpmbuild/cashe/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
cashe
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define auto_sitelib 1,
%{!?python_sitelib: %define python_sitelib %(python -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")},
%define python_sitelib /usr/lib/python?.?/site-packages
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: cashe-0.99.2-1.fc21.noarch.rpm
python-cashe-0.99.2-1.fc21.noarch.rpm
cashe-0.99.2-1.fc21.src.rpm
python-cashe.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/cashe/__init__.py 0644L /usr/bin/python
python-cashe.noarch: E: incorrect-fsf-address
/usr/share/licenses/python-cashe/LICENSE
cashe.src:6: E: hardcoded-library-path in /usr/lib/python?.?/site-packages
3 packages and 0 specfiles checked; 3 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
python-cashe.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/cashe/__init__.py 0644L /usr/bin/python
python-cashe.noarch: E: incorrect-fsf-address
/usr/share/licenses/python-cashe/LICENSE
2 packages and 0 specfiles checked; 2 errors, 0 warnings.
Requires
--------
cashe (rpmlib, GLIBC filtered):
/usr/bin/python
python
python-cashe
python-cashe (rpmlib, GLIBC filtered):
python
python(abi)
Provides
--------
cashe:
CAShe
cashe
python-cashe:
python-cashe
Source checksums
----------------
https://github.com/james-antill/CAShe/archive/1549852fd1c2805ba6329309f97d11190c37256e/CAShe-1549852fd1c2805ba6329309f97d11190c37256e.tar.gz
:
CHECKSUM(SHA256) this package :
8bc01130459296b25c6f6ff974270a642e12cf4012ef36b790d890e9e01159aa
CHECKSUM(SHA256) upstream package :
8bc01130459296b25c6f6ff974270a642e12cf4012ef36b790d890e9e01159aa
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/bin/fedora-review -n SRPMS/cashe-0.99.2-1.fc21.src.rpm
--rpm-spec
Buildroot used: fedora-21-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list