[Bug 1278960] Review Request: nodejs-heap - Binary heap (priority queue) algorithms
bugzilla at redhat.com
bugzilla at redhat.com
Sat Nov 7 11:03:30 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1278960
--- Comment #3 from Tom Hughes <tom at compton.nu> ---
So per
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text I
think %license should only be used for files that only contain the license.
There's also a recommendation to ask upstream to put the license in a separate
file of course, but I'll leave that up to you.
As lib/heap.js is built from src/heap.coffee we should probably run coffee in
%build to recreate it.
The other issue is the comment that the tests are disabled (they're not) along
with the patch that is being applied to them without any explanation and which
doesn't seem to be needed as it builds OK without it on F22, F23 and Rawhide.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list