[Bug 1156086] Review Request: openmx - Open source package for Material eXplorer

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 8 16:24:15 UTC 2015 

https://bugzilla.redhat.com/show_bug.cgi?id=1156086

gil cattaneo <puntogil at libero.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #9 from gil cattaneo <puntogil at libero.it> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/gil/1156086-openmx/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[!]: Package contains no static executables.
 openmx3.7/source/liberi-091216/source/sbt/linear/eri_linfsbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/sbt/log/eri_fsbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/sbt/log/eri_logfsbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/sbt/eri_sbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_gtbl_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_interpolate_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_ll_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_sf_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/test/test/test_pp

[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[?]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 1086 files have unknown license.
     Detailed output of licensecheck in
     /home/gil/1156086-openmx/licensecheck.txt
  All source files are without license headers. Please, inform upstream to
confirm the licensing of code and/or content/s
  and ask to add license headers in those files where is missing
 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification
[!]: License file installed when any subpackage combination is installed.
  Please, inform upstream to add license and copyright notice in source
directory structure.
 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
[?]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[?]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[x]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[!]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openmx-
     openmpi , openmx-mpich , openmx-data , openmx-common , openmx-
     debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.2.13 starting (python version = 3.4.3)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
Mock Version: 1.2.13
INFO: Mock Version: 1.2.13
Finish: chroot init
INFO: installing package(s):
/home/gil/1156086-openmx/results/openmx-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-openmpi-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-mpich-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-data-3.7.10-1.fc24.noarch.rpm
/home/gil/1156086-openmx/results/openmx-common-3.7.10-1.fc24.noarch.rpm
/home/gil/1156086-openmx/results/openmx-debuginfo-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-debuginfo-3.7.10-1.fc24.i686.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/
--releasever 24 install
/home/gil/1156086-openmx/results/openmx-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-openmpi-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-mpich-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-data-3.7.10-1.fc24.noarch.rpm
/home/gil/1156086-openmx/results/openmx-common-3.7.10-1.fc24.noarch.rpm
/home/gil/1156086-openmx/results/openmx-debuginfo-3.7.10-1.fc24.i686.rpm
/home/gil/1156086-openmx/results/openmx-debuginfo-3.7.10-1.fc24.i686.rpm
--setopt=tsflags=nocontexts


Rpmlint
-------
Checking: openmx-3.7.10-1.fc24.i686.rpm
          openmx-openmpi-3.7.10-1.fc24.i686.rpm
          openmx-mpich-3.7.10-1.fc24.i686.rpm
          openmx-data-3.7.10-1.fc24.noarch.rpm
          openmx-common-3.7.10-1.fc24.noarch.rpm
          openmx-debuginfo-3.7.10-1.fc24.i686.rpm
          openmx-3.7.10-1.fc24.src.rpm
openmx.i686: W: spelling-error Summary(en_US) eXplorer -> explorer, explore,
explorers
openmx.i686: W: spelling-error %description -l en_US eXplorer -> explorer,
explore, explorers
openmx.i686: W: spelling-error %description -l en_US nano -> anon, Kano, Nona
openmx.i686: W: spelling-error %description -l en_US pseudopotentials -> pseudo
potentials, pseudo-potentials, potentials
openmx.i686: E: no-binary
openmx.i686: W: no-documentation
openmx-openmpi.i686: W: summary-not-capitalized C openmx - openmpi version
openmx-openmpi.i686: W: spelling-error %description -l en_US eXplorer ->
explorer, explore, explorers
openmx-openmpi.i686: W: spelling-error %description -l en_US nano -> anon,
Kano, Nona
openmx-openmpi.i686: W: spelling-error %description -l en_US pseudopotentials
-> pseudo potentials, pseudo-potentials, potentials
openmx-openmpi.i686: W: no-documentation
openmx-mpich.i686: W: summary-not-capitalized C openmx - mpich version
openmx-mpich.i686: W: spelling-error %description -l en_US eXplorer ->
explorer, explore, explorers
openmx-mpich.i686: W: spelling-error %description -l en_US nano -> anon, Kano,
Nona
openmx-mpich.i686: W: spelling-error %description -l en_US pseudopotentials ->
pseudo potentials, pseudo-potentials, potentials
openmx-mpich.i686: W: no-documentation
openmx-data.noarch: W: summary-not-capitalized C openmx - data files
openmx-data.noarch: W: spelling-error %description -l en_US eXplorer ->
explorer, explore, explorers
openmx-data.noarch: W: spelling-error %description -l en_US nano -> anon, Kano,
Nona
openmx-data.noarch: W: spelling-error %description -l en_US pseudopotentials ->
pseudo potentials, pseudo-potentials, potentials
openmx-data.noarch: W: no-documentation
openmx-common.noarch: W: summary-not-capitalized C openmx - common files
openmx-common.noarch: W: spelling-error %description -l en_US eXplorer ->
explorer, explore, explorers
openmx-common.noarch: W: spelling-error %description -l en_US nano -> anon,
Kano, Nona
openmx-common.noarch: W: spelling-error %description -l en_US pseudopotentials
-> pseudo potentials, pseudo-potentials, potentials
openmx-common.noarch: W: no-documentation
openmx.src: W: spelling-error Summary(en_US) eXplorer -> explorer, explore,
explorers
openmx.src: W: spelling-error %description -l en_US eXplorer -> explorer,
explore, explorers
openmx.src: W: spelling-error %description -l en_US nano -> anon, Kano, Nona
openmx.src: W: spelling-error %description -l en_US pseudopotentials -> pseudo
potentials, pseudo-potentials, potentials
openmx.src: W: strange-permission solve_evp_real.f90.solve_tridi.patch 600
openmx.src: W: strange-permission solve_evp_complex.f90.solve_tridi.patch 600
openmx.src:128: W: mixed-use-of-spaces-and-tabs (spaces: line 128, tab: line
40)
7 packages and 0 specfiles checked; 1 errors, 32 warnings.




Requires
--------
openmx-openmpi (rpmlib, GLIBC filtered):
    libc.so.6
    libelpa.so.3(openmpi-i386)
    libfftw3.so.3
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.3.1)
    libgfortran.so.3
    libgfortran.so.3(GFORTRAN_1.0)
    libgfortran.so.3(GFORTRAN_1.4)
    libgomp.so.1
    libgomp.so.1(GOMP_1.0)
    libgomp.so.1(GOMP_4.0)
    libgomp.so.1(OMP_1.0)
    libgomp.so.1(OMP_2.0)
    libm.so.6
    libmpi.so.12(openmpi-i386)
    libmpi_mpifh.so.12(openmpi-i386)
    libmpi_usempif08.so.11(openmpi-i386)
    libopenblas.so.0
    libpthread.so.0
    openmx-data
    rtld(GNU_HASH)

openmx-common (rpmlib, GLIBC filtered):

openmx-mpich (rpmlib, GLIBC filtered):
    libc.so.6
    libelpa.so.3(mpich-i386)
    libfftw3.so.3
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.3.1)
    libgfortran.so.3
    libgfortran.so.3(GFORTRAN_1.0)
    libgfortran.so.3(GFORTRAN_1.4)
    libgomp.so.1
    libgomp.so.1(GOMP_1.0)
    libgomp.so.1(GOMP_4.0)
    libgomp.so.1(OMP_1.0)
    libgomp.so.1(OMP_2.0)
    libm.so.6
    libmpi.so.12(mpich-i386)
    libmpifort.so.12(mpich-i386)
    libopenblas.so.0
    libpthread.so.0
    openmx-data
    rtld(GNU_HASH)

openmx-data (rpmlib, GLIBC filtered):
    openmx-common

openmx (rpmlib, GLIBC filtered):
    openmx-data
    openssh-clients

openmx-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
openmx-openmpi:
    openmx-openmpi
    openmx-openmpi(x86-32)

openmx-common:
    openmx-common

openmx-mpich:
    openmx-mpich
    openmx-mpich(x86-32)

openmx-data:
    openmx-data

openmx:
    openmx
    openmx(x86-32)

openmx-debuginfo:
    openmx-debuginfo
    openmx-debuginfo(x86-32)



Source checksums
----------------
http://www.openmx-square.org/openmx3.7.tar.gz :
  CHECKSUM(SHA256) this package     :
24329cd1fbad98d6cb99b04e4d988b0715e2ce3156f79e4855c46f93a0c981f9
  CHECKSUM(SHA256) upstream package :
4e3490007e7acbfdd29d32008c8fdec7e678a448cfd74aad13bce2dc5e9fc622
http://www.openmx-square.org/bugfixed/15Feb21/patch3.7.10.tar.gz :
  CHECKSUM(SHA256) this package     :
dce84baeb56f9f0eee036d2d79825bb8ee25a0cf8cfbcf1719ad34630c5a8c12
  CHECKSUM(SHA256) upstream package :
dce84baeb56f9f0eee036d2d79825bb8ee25a0cf8cfbcf1719ad34630c5a8c12
diff -r also reports differences


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1156086 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

More information about the package-review mailing list