[Bug 1281538] Review Request: umlgraph - Automated Drawing of UML Diagrams

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1281538



--- Comment #4 from gil cattaneo <puntogil at libero.it> ---
Issues:

[!]: Packages should try to preserve timestamps of original installed
     files.

NON blocking issues:

- Maven packages should use new style packaging
  Note: If possible update your package to latest guidelines
  See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven
 Please, consider this option

[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 260 files have
     unknown license. Detailed output of licensecheck in
     /home/gil/1281538-umlgraph/licensecheck.txt

These java source files are without license headers. Please, ask to upstream to
add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/ContextView.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/InterfaceMatcher.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/PackageMatcher.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/PackageView.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/RelationDirection.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/RelationPattern.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/RelationType.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/SubclassMatcher.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/UmlGraphDoc.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/UMLOptions.java

This file should be regenerate
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/Version.java
see buld.xml @ line 52

[?]: Requires correct, justified where necessary.

[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
   Please, remove %%doc macro in javadoc sub package

[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component