[Bug 1274568] Review Request: gap-pkg-semigroups - GAP methods for semigroups
bugzilla at redhat.com
bugzilla at redhat.com
Fri Nov 13 23:03:26 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1274568
Sandro Mani <manisandro at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Sandro Mani <manisandro at gmail.com> ---
Approved with the following remarks:
-> I guess these rpmlint errors can be ignored since I suppose that it is
better to install the docs for the packages, even if they are empty, than not
installing them:
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/greens-acting.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/greens-generic.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/acting.xml
-> As in #1281664, I see in the build.log:
gap> #I #I Composing XML document . . .
#I #I Parsing XML document . . .
#I #I Checking XML structure . . .
#I #I Text version (also produces labels for hyperlinks):
#I #I First run, collecting cross references, index, toc, bib and so on . . .
Filename( dirs, "manual.six" ) called from
HELP_BOOK_INFO( bookname ) called from
GAPDoc2TextProcs.ResolveExternalRef( r.attributes.BookName, lab, 1
) called from
GAPDoc2TextProcs.(r.name)( r, str ); called from
GAPDoc2Text( a, s ); called from
... at line 2 of *stdin*
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Filename' on 2 arguments called from
brk> brk> #I File:
/builddir/build/BUILD/semigroups-2.6/../pkg/semigroups-2.6/doc/manual.lab
written.
brk> gap> + rm -fr ../../doc ../pkg
+ exit 0
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: gap-pkg-semigroups-2.6-1.fc24.noarch.rpm
gap-pkg-semigroups-2.6-1.fc24.src.rpm
gap-pkg-semigroups.noarch: W: spelling-error %description -l en_US monoids ->
mono ids, mono-ids, mongoloids
gap-pkg-semigroups.noarch: W: spelling-error %description -l en_US bipartitions
-> bi partitions, bi-partitions, partitions
gap-pkg-semigroups.noarch: W: spelling-error %description -l en_US
subsemigroups -> subgroups
gap-pkg-semigroups.noarch: W: spelling-error %description -l en_US semigroup ->
semi group, semi-group, semipro
gap-pkg-semigroups.noarch: W: spelling-error %description -l en_US congruences
-> congruence, congruence's, congruence s
gap-pkg-semigroups.noarch: W: spelling-error %description -l en_US normalizer
-> normalize, normalizes, normalized
gap-pkg-semigroups.noarch: W: only-non-binary-in-usr-lib
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/grpperm.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/greens-acting.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/greens-generic.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/acting.xml
gap-pkg-semigroups.src: W: spelling-error %description -l en_US monoids -> mono
ids, mono-ids, mongoloids
gap-pkg-semigroups.src: W: spelling-error %description -l en_US bipartitions ->
bi partitions, bi-partitions, partitions
gap-pkg-semigroups.src: W: spelling-error %description -l en_US subsemigroups
-> subgroups
gap-pkg-semigroups.src: W: spelling-error %description -l en_US semigroup ->
semi group, semi-group, semipro
gap-pkg-semigroups.src: W: spelling-error %description -l en_US congruences ->
congruence, congruence's, congruence s
gap-pkg-semigroups.src: W: spelling-error %description -l en_US normalizer ->
normalize, normalizes, normalized
2 packages and 0 specfiles checked; 4 errors, 13 warnings.
Rpmlint (installed packages)
----------------------------
gap-pkg-semigroups.noarch: W: only-non-binary-in-usr-lib
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/greens-acting.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/grpperm.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/acting.xml
gap-pkg-semigroups.noarch: E: zero-length
/usr/lib/gap/pkg/semigroups/doc/greens-generic.xml
1 packages and 0 specfiles checked; 4 errors, 1 warnings.
Requires
--------
gap-pkg-semigroups (rpmlib, GLIBC filtered):
gap-core
gap-pkg-io
gap-pkg-orb
Provides
--------
gap-pkg-semigroups:
gap-pkg-semigroups
Source checksums
----------------
http://www-groups.mcs.st-andrews.ac.uk/~jamesm/semigroups/semigroups-2.6.tar.gz
:
CHECKSUM(SHA256) this package :
38b9f04601be01e77701870d395371fedd873af392fa8f6fd985991ececce88b
CHECKSUM(SHA256) upstream package :
38b9f04601be01e77701870d395371fedd873af392fa8f6fd985991ececce88b
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1274568
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list