[Bug 1222334] Review Request: bup - Efficient backup system based on git

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1222334



--- Comment #8 from Tadej Janež <tadej.j at nez.si> ---
Hi William,

thanks for the review!

Sorry that it took so long to reply. While fixing the package, I encountered
some problems that needed quite some time to get fixed.

(In reply to William Moreno from comment #2)
> Package Review
> ==============
> 
> Need Work:
> [ ]: Development (unversioned) .so files in -devel subpackage, if present.
>      Note: Unversioned so-files in private %_libdir subdirectory (see
>      attachment). Verify they are not in ld path.

I assume you are referring to /usr/lib64/bup/bup/_helpers.so, which is also
listed below.
The _helpers.so file represents a private shared library which is not meant for
development purposes, rather it is an essential part of bup (you can check this
with a simple 'grep -rni _helpers' on the bup source code directory).
Since it is a private shared library, it shouldn't be added as "Provides" for
other packages [1].

> 2- There is a daemon command than work as a system service so you will to
> provide a unit service file to handle the service with systemd.
> https://fedoraproject.org/wiki/Packaging:Systemd

Done.

I've decided to split-out "bup web" into a separate subpackage.
Since the nature of "bup web" is to run a web server for browsing through bup
repositories, it only makes sense to provide a systemd unit file for running
"bup web" as a service with the systemd user instance (i.e. 'systemd --user').

Along the way, I discovered that there are no guidelines for packaging user
instance services [2].
I also encountered two bugs while trying to use systemd's %systemd_user_post
macro and fixed them [3].
To make it easier for the user who would want to use the bup-web user service,
I've written a Fedora README [4].

> Test Builds:
> Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=11351834 (Failed)
> ARM:  http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3219703 (Failed)
> PPC:  http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2785514 (Failed)
> S390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1953880
> (Failed)
> 
> My local build run fine in mock but al kojis test build in rawhide are
> failing see:
> Can't locate Time/HiRes.pm in @INC (you may need to install the Time::HiRes
> module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5
> /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5
> /usr/share/perl5 .) at ./wvtestrun line 10.
> BEGIN failed--compilation aborted at ./wvtestrun line 10.
> Makefile:130: recipe for target 'test' failed
> 
> Looks like a missing BuildRequires

Yes, it was a missing BuildRequires. Fixed.

Subsequently, I encountered a problem with a failing test. I temporarily
disabled it, as you suggested and I'm working with upstream to fix it.

> Unversioned so-files
> --------------------
> bup: /usr/lib64/bup/bup/_helpers.so

Already addressed above.

The new Spec URL: https://github.com/tjanez/bup-package/blob/ff9588f/bup.spec
The new SRPM URL: https://tadej.fedorapeople.org/bup-0.27-0.3.fc23.src.rpm

Thanks and best regards,
Tadej


[1] https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

[2]
https://lists.fedoraproject.org/archives/list/packaging%40lists.fedoraproject.org/thread/VKTC6FSQGX6DUQAZHC7F6ZEUFXHRTD4F/

[3] https://github.com/systemd/systemd/pull/1986

[4]
https://github.com/tjanez/bup-package/blob/ff9588fa67e6e431c24371c673b9e32656b362d7/README-bup-web.Fedora.md

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component