[Bug 1284527] Review Request: opal-prd - OPAL Processor Recovery Diagnostics daemon

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1284527

Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody at fedoraproject.org    |dan at danny.cz
              Flags|                            |fedora-review?



--- Comment #16 from Dan Horák <dan at danny.cz> ---
- distro-wide CFLAGS are not honoured in the build -
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
- make the build of opal-prd verbose so the full command lines are visible (add
V=1)
- you should drop the "$RPM_BUILD_DIR/skiboot-skiboot-%version/" string from
the make commands, it's the default dir for rpm builds (see build.log)
- I think you don't need kernel-devel and playing with the KERNEL_DIR at all,
the asm/opal-prd.h file is part of the kernel-headers package which is
installed together with glibc-headers as it is a public API
(http://ppc.koji.fedoraproject.org/koji/fileinfo?rpmID=2562590&filename=/usr/include/asm/opal-prd.h)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component