[Bug 1197333] Review Request: polyglot-chess - Polyglot chess opening book program

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1197333



--- Comment #10 from Ankur Sinha (FranciscoD) <sanjay.ankur at gmail.com> ---
Looks pretty good! Just some minor rpmlint issues, and it'll be good to go!


[+] OK
[-] NA
[?] Issue

** Mandatory review guidelines: **
 [?] rpmlint output:
   Minor issues:
asinha at cs-as14aho-2-herts-ac-uk  SRPMS]$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/*rpm ../SPECS/polyglot-chess.spec
./polyglot-chess-1.4-4.20140902gitf46ee06.fc23.src.rpm 
polyglot-chess.src: W: spelling-error %description -l en_US xboard -> board,
aboard, x board
polyglot-chess.src: W: spelling-error %description -l en_US leveldb -> level
db, level-db, level
polyglot-chess.x86_64: W: spelling-error %description -l en_US xboard -> board,
aboard, x board
polyglot-chess.x86_64: W: spelling-error %description -l en_US leveldb -> level
db, level-db, level
polyglot-chess.x86_64: E: incorrect-fsf-address
/usr/share/licenses/polyglot-chess/LICENSE
polyglot-chess.x86_64: E: incorrect-fsf-address
/usr/share/doc/polyglot-chess/readme.txt
polyglot-chess.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/polyglot-chess/example-files/fruit_book_linux.ini
polyglot-chess.x86_64: W: spurious-executable-perm
/usr/share/man/man6/polyglot-chess.6.gz
polyglot-chess.src: W: spelling-error %description -l en_US xboard -> board,
aboard, x board
polyglot-chess.src: W: spelling-error %description -l en_US leveldb -> level
db, level-db, level
4 packages and 1 specfiles checked; 2 errors, 8 warnings.

 [+] License is acceptable
 [+] License field in spec is correct
 [+] License files included in package %docs if included in source package
 [+] License files installed when any subpackage combination is installed
 [+] Spec written in American English
 [+] Spec is legible
 [-] Sources match upstream unless altered to fix permissibility issues
 [+] Build succeeds on at least one primary arch
 [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed
 [+] BuildRequires correct, justified where necessary
 [-] Locales handled with %find_lang, not %_datadir/locale/*
 [-] %post, %postun call ldconfig if package contains shared .so files
 [+] No bundled libs
 [-] Relocatability is justified
 [+] Package owns all directories it creates
 [-] Package requires others for directories it uses but does not own
 [+] No duplication in %files unless necessary for license files
 [+] File permissions are sane
 [+] Package contains permissible code or content
 [-] Large docs go in -doc subpackage
 [+] %doc files not required at runtime
 [-] Static libs go in -static package/virtual Provides
 [-] Development files go in -devel package
 [-] -devel packages Require base with fully-versioned dependency, %_isa
 [-] No .la files
 [?] GUI app uses .desktop file, installs it with desktop-file-install
    Doesn't appear to be a GUI application

 [-] File list does not conflict with other packages' without justification
 [+] File names are valid UTF-8

** Optional review guidelines: **
 [-] Query upstream about including license files
 [-] Translations of description, summary
 [+] Builds in mock
 [+] Builds on all arches
 [?] Functions as described (e.g. no crashes)
    Please check this ;)

 [-] Scriptlets are sane
 [-] Subpackages require base with fully-versioned dependency if sensible
 [-] .pc file subpackage placement is sensible
 [+] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin
 [+] Include man pages if available

Naming guidelines:
 [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+
 [+] Package names are sane
 [+] No naming conflicts
 [+] Spec file name matches base package name
 [+] Version is sane
 [+] Version does not contain ~
 [+] Release is sane
 [+] %dist tag
 [-] Case used only when necessary
 [-] Renaming handled correctly

Packaging guidelines:
 [+] Useful without external bits
 [-] No kmods
 [-] Pre-built binaries, libs removed in %prep
 [+] Sources contain only redistributable code or content
 [+] Spec format is sane
 [+] Package obeys FHS, except libexecdir, /run, /usr/target
 [+] No files in /bin, /sbin, /lib* on >= F17
 [-] Programs run before FS mounting use /run instead of /var/run
 [-] Binaries in /bin, /sbin do not depend on files in /usr on < F17
 [+] No files under /srv, /opt, /usr/local
 [+] Changelog in prescribed format
 [+] No Packager, Vendor, Copyright, PreReq tags
 [+] Summary does not end in a period
 [+] Correct BuildRoot tag on < EL6
 [+] Correct %clean section on < EL6
 [-] Requires correct, justified where necessary
 [-] Summary, description do not use trademarks incorrectly
 [+] All relevant documentation is packaged, appropriately marked with %doc
 [+] Doc files do not drag in extra dependencies (e.g. due to +x)
 [+] Code compilable with gcc is compiled with gcc
 [+] Build honors applicable compiler flags or justifies otherwise
 [-] PIE used for long-running/root daemons, setuid/filecap programs
 [+] Useful -debuginfo package or disabled and justified
 [-] Package with .pc files Requires pkgconfig on < EL6
 [+] No static executables
 [+] Rpath absent or only used for internal libs
 [-] Config files marked with %config(noreplace) or justified %config
 [+] No config files under /usr
 [-] Third party package manager configs acceptable, in %_docdir
 [-] .desktop files are sane
 [+] Spec uses macros consistently
 [+] Spec uses macros instead of hard-coded names where appropriate
 [-] Spec uses macros for executables only when configurability is needed
 [-] %makeinstall used only when alternatives don't work
 [-] Macros in Summary, description are expandable at srpm build time
 [+] Spec uses %{SOURCE#} instead of $RPM_SOURCE_DIR and %sourcedir
 [+] No software collections (scl)
 [-] Macro files named /etc/rpm/macros.%name
 [-] Build uses only python/perl/shell+coreutils/lua/BuildRequired langs
 [+] %global, not %define
 [+] Package translating with gettext BuildRequires it
 [+] Package translating with Linguist BuildRequires qt-devel
 [+] File ops preserve timestamps
 [+] Parallel make
 [+] No Requires(pre,post) notation
 [-] User, group creation handled correctly (See Packaging:UsersAndGroups)
 [-] Web apps go in /usr/share/%name, not /var/www
 [-] Conflicts are justified
 [+] One project per package
 [+] No bundled fonts
 [+] Patches have appropriate commentary
 [-] Available test suites executed in %check
 [-] tmpfiles.d used for /run, /run/lock on >= F15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component