[Bug 1277415] Review Request: php-nette-http - Nette HTTP Component

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1277415

Shawn Iwinski <shawn at iwin.ski> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Shawn Iwinski <shawn at iwin.ski> ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



[x]: Requires correct, justified where necessary.

     From composer.json:
         "nette/utils": "~2.2, >=2.2.2"
     For spec:
         #        "nette/utils": "~2.2"
         Requires:       php-composer(%{gh_owner}/utils) >= 2.2



[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).

Diff spec file in url and in SRPM
---------------------------------
--- 1277415-php-nette-http/srpm/php-nette-http.spec    2015-11-28
10:25:06.305750424 -0500
+++ 1277415-php-nette-http/srpm-unpacked/php-nette-http.spec    2015-10-30
09:11:33.000000000 -0400
@@ -102,6 +102,6 @@
 %check
 %if %{with_tests}
-%if 0%{?rhel} == 7
 : Ignore failed test - only bad message
+%if 0%{?rhel} == 7
 rm tests/Http/Session.start.error.phpt
 %endif



No blockers.

===== APPROVED =====

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component