[Bug 1267037] Review Request: perl-Mojolicious-Plugin-Bootstrap3 - Mojolicious + http://getbootstrap.com/

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1267037



--- Comment #1 from Petr Šabata <psabata at redhat.com> ---
* The package fails to build in mock -- see the next bullet.

* Define NO_PACKLIST or delete the .packlist files manually.
  You probably wanted to use the former but simply forgot to put there.

* Missing a builddep called in the spec file: make

* Missing a builddep used during the %check phase:
  - perl(Mojolicious::Plugin), lib/Mojolicious/Plugin/Bootstrap3.pm:233

* Mojolicious::Lite doesn't appear to be used anywhere; it's only
  mentioned in POD.

* According to META.*, the required version of Mojolicious::Plugin::AssetPack
  is 0.67, not 0.58.

* Mojolicious::Plugin::AssetPack won't be autodetected.
  Require it explicitly, including the correct version constraint.

* Even though it's not used directly, consider adding a runtime dependency
  on Mojolicious 6.00+.

* The minimum required version of Test::More is 0.88.  You could reflect
  that in your package as well.

* I understand it's the whole point of this package but this ships bundled
  fonts, JavaScript (jQuery and many others) and Sass content.
  That doesn't seem right.  The package should probably be patched to
  use the data provided by Fedora packages or acquire proper exceptions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component