[Bug 1268010] Review Request: libmooshika - helper library for RDMA

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1268010

Dave Love <d.love at liverpool.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d.love at liverpool.ac.uk



--- Comment #1 from Dave Love <d.love at liverpool.ac.uk> ---
Unfortunately I can't review this properly as I can't run ganesha so
can't test it.  However, here are some quick comments on the spec
file.

* I don't know if you want to support it, but the Group tag is only
  needed for EPEL5;

* You normally shouldn't add explicit Requires for dynamic libraries
  except typically for devel packages depending on the non-devel
  version -- the packaging will usually do that automatically. 
  For the devel package the Requires should normally be like

  %package        devel
  Requires:       %{name}-libs%{?_isa} = %{version}-%{release}
  ...

* make should have an argument %{?_smp_mflags} in the %build section,
  or a comment that it's not smp-safe;

* Don't package .la files (and normally not .a).  Under %files, You
  can use instead

  %exclude %{_libdir}/*a

  but you need .so in the devel package, not the main one;

* You need to add

  %post -p /sbin/ldconfig
  %postun -p /sbin/ldconfig

Sorry not to give references to the packaging guide for each item, but
I hope that helps, and it's easy to fix.  Don't be put off!  rpmlint
should warn about some of it, and it's worth running fedora-review on
the package (if you can -- I have trouble on an EPEL6 system).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component