[Bug 1231318] Review Request: php-zordius-lightncandy - An extremely fast PHP implementation of handlebars and mustache

Fri Oct 9 18:33:19 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1231318


--- Comment #23 from gil cattaneo <puntogil at libero.it> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 12 files have
     unknown license. Detailed output of licensecheck in /home/gil/1231318
     -php-zordius-lightncandy/licensecheck.txt
[-]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/php/zordius
[?]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/php/zordius
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

PHP:
[x]: Run phpci static analyze on all php files.
     Note: phpCompatInfo version 4.4.0 DB built Jul 20 2015 15:06:38 CEST
     static analyze results in /home/gil/1231318-php-zordius-
     lightncandy/phpci.log


Rpmlint
-------
Checking: php-zordius-lightncandy-0.22-1.fc24.noarch.rpm
          php-zordius-lightncandy-0.22-1.fc24.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: File o directory non esistente
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


Requires
--------
php-zordius-lightncandy (rpmlib, GLIBC filtered):
    php(language)
    php-pcre
    php-reflection
    php-spl


Provides
--------
php-zordius-lightncandy:
    php-composer(zordius/lightncandy)
    php-zordius-lightncandy


Source checksums
----------------
https://github.com/mustache/spec/archive/83b0721610a4e11832e83df19c73ace3289972b9.tar.gz#/php-zordius-lightncandy-mustache.tar.gz
:
  CHECKSUM(SHA256) this package     :
3b4c2a730de7dfdb2ef8035bb6ddfa2091d66418c665b57a039f8ddd494ebd48
  CHECKSUM(SHA256) upstream package :
3b4c2a730de7dfdb2ef8035bb6ddfa2091d66418c665b57a039f8ddd494ebd48
https://github.com/zordius/lightncandy/archive/v0.22.tar.gz#/php-zordius-lightncandy-0.22.tar.gz
:
  CHECKSUM(SHA256) this package     :
6a719340b5492873279930d18dc4a7a6a98a7015a8963aa8a395b84f70451a28
  CHECKSUM(SHA256) upstream package :
6a719340b5492873279930d18dc4a7a6a98a7015a8963aa8a395b84f70451a28
https://github.com/kasperisager/handlebars-spec/archive/df077dd262eea766648af0b6efd8a22e44c78178.tar.gz#/php-zordius-lightncandy-handlebars.tar.gz
:
  CHECKSUM(SHA256) this package     :
de637882c99e3716ac913107418afc0dc671a781dbc1cb433ed73d206f52561c
  CHECKSUM(SHA256) upstream package :
de637882c99e3716ac913107418afc0dc671a781dbc1cb433ed73d206f52561c


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1231318 --plugins PHP -m
fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component