[Bug 1090499] Review Request: netresolve - Generic name resolution library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1090499



--- Comment #21 from Pavel Šimerda (pavlix) <psimerda at redhat.com> ---
(In reply to Jiri Popelka from comment #20)
> [!]: ldconfig called in %post and %postun if required.
>   Note: /sbin/ldconfig not called in netresolve-core, netresolve-compat,
>   netresolve-backends-compat, netresolve-backends-aresdns, netresolve-
>   backends-avahi, netresolve-backends-ubdns
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

OK.

> [!]: If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file COPYING is marked as %doc instead of %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

OK.

> [!]: License field in the package spec file matches the actual license.
>      Note: baskends/asyncns.c is LGPLv2+ licensed

TODO: Will fix upstream and import the new changes.

> [!]: License file installed when any subpackage combination is installed.
>      Note: you need %license COPYING in each %files section
>      (except the main package and -tools/-compat subpackages AFAICT)

TODO: Will reconsider the dependencies and fix it.

> [!]: Fully versioned dependency in subpackages if applicable.
>      Note: It'd better to replace for example
>      - Requires: netresolve-core
>      + Requires: netresolve-core%{?_isa} = %{version}-%{release}
>      (the same for all subpackages)

OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component