[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Luya Tshimbalanga <luya at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(ogabbay at redhat.co
                   |                            |m)



--- Comment #8 from Luya Tshimbalanga <luya at fedoraproject.org> ---
(In reply to Oded Gabbay from comment #7)
> Because you are using a wrong link.
> It's not
> https://wiki.freedesktop.org/xorg/archive/individual/lib/hsakmt-1.0.0.tar.bz2
> 
> It's http://xorg.freedesktop.org/archive/individual/lib/hsakmt-1.0.0.tar.bz2

It turned out HTTPS Everywhere extenision for Firefox caused the 404 error by
replacing http with https. Disable it led me to get the tarball. 

-------
Looking at the spec files, could you fix the following:

- Package uses either %{buildroot} or $RPM_BUILD_ROOT on that following line

> make install DESTDIR=$RPM_BUILD_ROOT
>
> find %{buildroot} -type f -name "*.la" -delete


I will personally suggest using %{buildroot} for consistency

--------------------

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

--------------------

- According to license check from fedora-review script, hsakmt source tarball
has two licenses which should be reflected on the spec file:

GPL (v2 or later)
-----------------
hsakmt-1.0.0/ltmain.sh

MIT/X11 (BSD like)
------------------
hsakmt-1.0.0/COPYING
hsakmt-1.0.0/hsakmt/debug.c
hsakmt-1.0.0/hsakmt/events.c
hsakmt-1.0.0/hsakmt/fmm.c
hsakmt-1.0.0/hsakmt/fmm.h
hsakmt-1.0.0/hsakmt/globals.c
hsakmt-1.0.0/hsakmt/hsakmt-version.h.in
hsakmt-1.0.0/hsakmt/include/hsakmt.h
hsakmt-1.0.0/hsakmt/include/hsakmttypes.h
hsakmt-1.0.0/hsakmt/include/linux/kfd_ioctl.h
hsakmt-1.0.0/hsakmt/libhsakmt.h
hsakmt-1.0.0/hsakmt/memory.c
hsakmt-1.0.0/hsakmt/openclose.c

--------------------------
- AutoTools result from fedora-review script: Obsoleted m4s found
------------------------------
  AC_PROG_LIBTOOL found in: hsakmt-1.0.0/configure.ac:70 is replaced by 
LT_INIT. See https://fedorahosted.org/FedoraReview/wiki/AutoTools for details

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component