[Bug 1259532] Review Request: feedreader - RSS desktop client

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1259532

Miroslav Suchý <msuchy at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msuchy at redhat.com



--- Comment #5 from Miroslav Suchý <msuchy at redhat.com> ---
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in feedreader
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database

> FeedReader-1.2.1/src/Widgets/ModeButton.vala
This file seems to have LGPLv3 license (instead of GPLv3). Either clarify it
with upstream or put in SPEC
   License:        GPLv3+ and LGPLv3+
and in comment state what file use that LGPLv3+.

Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/rue,
     /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES,
     /usr/share/locale/ckb

Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/locale/rue/LC_MESSAGES, /usr/share/dbus-1,
     /usr/share/locale/ckb/LC_MESSAGES, /usr/share/locale/ckb,
     /usr/share/locale/rue, /usr/share/dbus-1/services

> BuildRequires:  pkgconfig(sqlite3)
While this is technically speaking correct, it is very unusual at the same
time.
It can confuse other packagers. I would use real name of the package who
provide it. I.e.
BuildRequires: sqlite-devel
And the same for all pkgconfig(*) BR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component