[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1221781



--- Comment #14 from Richard Shaw <hobbes1069 at gmail.com> ---
(In reply to Raphael Groner from comment #13)
> - Sources used to build the package match the upstream source, as provided
>   in the spec URL.
>   Note: Upstream MD5sum check error, diff is in /home/builder/fedora-
>   review/1221781-zipios/diff.txt
>   See: http://fedoraproject.org/wiki/Packaging/SourceURL

I still don't know what's going on here, here's the MD5 of the source I have:
$ md5sum zipios-2.1.0.tar.gz
5792930807096e4d23209a827338b3ab  zipios-2.1.0.tar.gz

I then downloaded it again to a different file name:
$ md5sum zipios-2.1.0_sf.tar.gz
5792930807096e4d23209a827338b3ab  zipios-2.1.0_sf.tar.gz

Looks the same to me.


> => Catch header file from Source link is another one than in SRPM. Please
> ensure it's the same.

Since I'm downloading from "master" it may change from time to time. I
re-downloaded now but I don't think it's an issue in either case.


> - Boost license for Catch. Please mention this in License tag and include
> the license text in the package.

Since it is only used for unit testing and does not get installed it's not part
of the resultant package. The headers are only compiled into the zipios_tests
binary.


> - 52 source files with E: incorrect-fsf-address, did you notify upstream?
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

I will.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component