[Bug 1263938] Review Request: perl-Etsy-StatsD - Object-Oriented Client for Etsy's StatsD Server

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1263938



--- Comment #3 from Petr Šabata <psabata at redhat.com> ---
(In reply to Jan Holcapek from comment #2)
> > * %description needs to end with a fullstop.
> >   In your case, consider simple `%{summary}.'
> > 
> > * Feel free to use the more common DESTDIR rather than PERL_INSTALL_ROOT.
> > 
> > * Missing build deps ;)
> >   - coreutils, called in spec, line 32
> >   - findutils, ditto
> >   - make, called in spec, lines 27, 30 and 37
> >   - perl(IO::Socket::INET), lib/Etsy/StatsD.pm:35
> > 
> > * For obvious reasons, the automatic generators won't find that
> > IO::Socket::INET dependency for you.  You'll have to require it explicitly.
> 
> All above fixed.

Ack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component