[Bug 1317887] Review Request: libfastjson - C json library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1317887

Rich Megginson <rmeggins at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rmeggins at redhat.com



--- Comment #1 from Rich Megginson <rmeggins at redhat.com> ---
Looks good.  rpmlint check passes.  Only a couple of minor issues:

"
BuildRequires:    autoconf
BuildRequires:    automake
BuildRequires:    libtool
BuildRequires:    glibc-common
"

Does the build actually require autoconf, automake, libtool?  I don't see any
call to `autoreconf` or the like.  Does the build require gcc?  Other similar
build tools?  Looks like glibc-common is for iconv.  I suggest using

"
BuildRequires:  glibc-common
BuildRequires:  gcc
"

Please make sure the Changelog section looks like this:
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
That is, line begins with a dash "-" followed by a single space " " followed by
the text.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component