[Bug 1309691] Review Request: hid-replay - debug tools for HID devices

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1309691



--- Comment #2 from Benjamin Tissoires <btissoir at redhat.com> ---
Spec URL:
https://people.freedesktop.org/~tissoire/hid-replay-rpm-v2/hid-replay.spec
SRPM URL:
https://people.freedesktop.org/~tissoire/hid-replay-rpm-v2/hid-replay-0.7.1-1.fc23.src.rpm

(In reply to Peter Hutterer from comment #1)
> BuildRoot: is obsolete now

removed

> defattr can be skipped, it just sets defaults anyway (there was a recent
> thread on fedora-devel)

removed

> you need to add %license COPYING

done (and added the files to the final RPM)

> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#License_Text
> [these three also apply to the libratbag review]
> 
> tbh, I find %{bindir}/%{name} more confusing than just spelling it out,
> especially given that you have a second binary anyway. same with the man page

OK, changed.

> 
> also, do me a favour for this one and the libratbag bug: run fedora-review
> -b <bugnumber> and fix up whatever else it complains about :)

Running the f23 fedora-review takes too long due to some annoying bugs fixed in
the devel version. Running the devel branch
(https://fedorahosted.org/FedoraReview/wiki/UseDevelopmentVersion) makes things
take like 10 min, which is acceptable.

I have the following which I think are OK:

in SHOULD:
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hid-
     replay-debuginfo
-> there is nothing in the specfile concerning the debuginfo, so these are
default ones.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
-> the patch I currently have in the specfile allows to compile on RHEL 6
without uhid. It's not upstream and won't be I think.
[ ]: %check is present and all tests pass.
-> no check upstream. I know, I might have to write some...
[ ]: Packages should try to preserve timestamps of original installed
     files.
-> ???? (not sure it applies to me)

Rpmlint:
Checking: hid-replay-0.7.1-1.fc24.x86_64.rpm
          hid-replay-debuginfo-0.7.1-1.fc24.x86_64.rpm
          hid-replay-0.7.1-1.fc24.src.rpm
hid-replay.x86_64: W: spelling-error %description -l en_US hidraw -> hi draw,
hi-draw, hid raw
hid-replay.x86_64: W: spelling-error %description -l en_US uhid -> hid, u hid,
uh id
hid-replay.src: W: spelling-error %description -l en_US hidraw -> hi draw,
hi-draw, hid raw
hid-replay.src: W: spelling-error %description -l en_US uhid -> hid, u hid, uh
id
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Well, uhid and hidraw are kernel modules, so it should not complain about
those!

Provides:
Should I also provide hid-recorder?


I also compressed the changelog into only one "Initial package".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component