[Bug 1310607] Review Request: qutebrowser - A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1310607



--- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> ---
- All the dependencies are used in python3 version, but cssutils is python2 -
is there any reason for that? IMO it's a typo.
- There are quite a lot hashbangs that point to /usr/bin/env. While there is
nothing in guidelines (that I know of) that would prohibit this, I'd advise
changing these to point to /usr/bin/python3. Consider this - someone might try
to run this in an environment where "/usr/bin/env python3" points to something
else than /usr/bin/python3. qutebrowser would likely fail since it wouldn't
find dependencies (dependencies that it has been built with and tested with by
you as a packager). By replacing the hashbangs, qutebrowser can keep working
even in environments like this (well, for the most part, anyway).

Otherwise everything looks good - the package builds and runs fine, rpmlint
output is clean, licensing is good and specfile looks very nice. Once the above
problems are solved, this package can be approved (oh, and I like that it's
Python 3!)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component