[Bug 1295209] Review Request: lua-fun - functional programming library for Lua and LuaJIT

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1295209



--- Comment #4 from Roman Tsisyk <roman at tsisyk.com> ---
> You should use %license for COPYING.md [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].

Fixed.

> Spec file name does not match srpm file name (it's missing the dash).

Fixed.

> Please add an empty build section:
> %build
> # nothing to do

Fixed.

> Add a dot at the end of both %description's.

Fixed.

Spec URL:
https://gist.githubusercontent.com/rtsisyk/e3b7d7d5574096aa22e2/raw/7ae6bd941a36d554d6455d763efdeb44e866ee50/lua-fun-0.1.2.spec
SRPM URL:
https://gist.github.com/rtsisyk/e3b7d7d5574096aa22e2/raw/7ae6bd941a36d554d6455d763efdeb44e866ee50/lua-fun-0.1.2-1.fc24.src.rpm
Buildbot: http://koji.fedoraproject.org/koji/taskinfo?taskID=12484092

--
> It would be great if you could do two-three reviews of other packages (e.g. anything from https://fedoraproject.org/PackageReviewStatus/NEW.html), so that potential sponsors know that you know the packaging guidelines and review workflow. https://fedoraproject.org/wiki/Packaging:Guidelines and the fedora-review tool are very useful.

Thanks a lot for your review for all my three packages! Your input is very
helpful for me.
I continuously improve my RPM skills by studying guidelines and policies and
making packages for software I use and/or maintain in upstream. I think that
review of some other packages  should be also useful  for this purpose. I will
take a look on some NEW packages soon. 

Please feel free to contact me if there is anything else to improve in my
packages. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component