[Bug 1292392] Review Request: libpwiz - ProteoWizard software library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1292392



--- Comment #4 from Antonio Trande <anto.trande at gmail.com> ---
(In reply to Denis Fateyev from comment #3)
> 
> Remarks:
> --------
> 1) Please fix license tag as mentioned above;
> 2) According the recent changes, all build requirements should present;
> 3) Ask upstream to use sane m4 macros (if possible);
> 4) Why these SourceXX? Couldn't these files be downloaded properly?

Source0 archive downloaded from a menu.
Source1 file downloaded from source files for Windows systems.

> 5) You can use '_hardened_build' without condition, since it won't break
> things anywhere (but it's up to you);
> 6) No manfiles for binaries is not good;
> 7) Missing description for 'pepcat' in 'tools' subpackage description;
> 8) For the whole spec uniformity, please put one BR per line, e.g.:
>   BuildRequires: libtool
>   BuildRequires: intltool
>      instead of:
>   BuildRequires: libtool, intltool
> 9) Despite "--as-needed", 'unused-direct-shlib-dependency' issue present,
> you could try eliminate it with a workaround from guidelines.

Spec URL: https://sagitter.fedorapeople.org/libpwiz/libpwiz.spec
SRPM URL:
https://sagitter.fedorapeople.org/libpwiz/libpwiz-3.0.9283-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component