[Bug 1294841] Review Request: fsvs - backup/restore/versioning/deployment tool

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 17 18:17:19 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1294841



--- Comment #4 from Antonio Trande <anto.trande at gmail.com> ---
- SPEC file must be named like software name.
  fsvs --> fsvs.spec

- License is uncorrect.
  http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL

- Why all these slash instead of a simple comma?
  backup/restore/versioning/deployment

- Please, use macros.
  http://fedoraproject.org/wiki/Packaging:RPMMacros

- Don't use %makeinstall
 
http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

- Use %license tag

- %clean section is not necessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list