[Bug 1298649] Review Request: php-interfasys-lognormalizer - Parses variables and converts them to string

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1298649

Shawn Iwinski <shawn at iwin.ski> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #8 from Shawn Iwinski <shawn at iwin.ski> ---
(In reply to Remi Collet from comment #7)
> From the source headers:
> 
> https://github.com/interfasys/lognormalizer/blob/master/src/Normalizer.php
> 
>  * This file is licensed under the Affero General Public License version 3 or
>  * later. See the COPYING file.
> 
> So I think, this is really "AGPLv3+" (of course, COPYING is the v3)

Sorry, I missed that.

[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 10 files have unknown license.



[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



No blockers.

===== APPROVED =====

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component