[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1301219



--- Comment #4 from Neal Gompa <ngompa13 at gmail.com> ---
Now that I can see your spec, I see a few things you can correct pretty
quickly.

* You do not need to do the export CFLAGS bit, as %configure handles that.

* %configure instead of %{configure}. I'm a bit hazy on this, but I think using
%{configure} can mess up some circumstances (but I'm not sure). In any case, it
makes stylistic sense to use %configure there anyway.

* %make_build instead of make %{?_smp_mflags}. Unless you are targeting EPEL
with this, you should use this instead, as it's cleaner and more obvious what
it is. (Actually, I believe %make_build now works in EL7 at least, so you could
probably get away with using it even there). 

* %make_install instead of "make install %{?_smp_mflags}
DESTDIR=${RPM_BUILD_ROOT}". Unless there's a very good reason to, you should
use %make_install.

* Unless you are targeting EL5, you do not need a %clean section.

* Instead of using ExclusiveArch, use "ExcludeArch: %{arm}", as you indicate
that only ARM is failing right now. Generally, you should only exclude
architectures that don't work, rather than making it only build on a subset of
architectures.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component