[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1301116



--- Comment #16 from Michel Normand <normand at linux.vnet.ibm.com> ---
(In reply to Dan Horák from comment #15)
> additional comments:
> - please update release for each iteration, it hard to track the changes
> made if it's kept the same and spec and srpms are overridden

I will do for next

> - you can drop also the "build" dir for man pages, it's a no-op at the end
> mkdir -p build/man3
> cp man3/*.3 build/man3

There are other files in  man3/ I do not want to package
this is the reason why i did a copy before to install build/man3/

> - I would use only VERS_LIB=%{version} otherwise it appends also ".1.fc24"
> which is not correct IMO

I will do

> - the libcxl.so symlink need to be created manually or the makefile be
> updated to create it, then "%files" should have
> %{_libdir}/libcxl.so.*
> and "%files devel" then
> %{_libdir}/libcxl.so

I am lost :( for me the symbolic link is created by ldconfig at install time
from the soname information present in the shipped so file
===
$ls -ltr /usr/lib64/libcxl.so*
-rwxr-xr-x. 1 root root 69216 mars   3 16:59 /usr/lib64/libcxl.so.1.3
lrwxrwxrwx. 1 root root    13 mars   3 17:00 /usr/lib64/libcxl.so.1 ->
libcxl.so.1.3
===
$rpm -ql libcxl
/usr/lib64/libcxl.so.1.3
/usr/share/doc/libcxl
/usr/share/doc/libcxl/README.md
/usr/share/licenses/libcxl
/usr/share/licenses/libcxl/LICENSE
===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component