[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1301116



--- Comment #17 from Michel Normand <normand at linux.vnet.ibm.com> ---
(In reply to Dan Horák from comment #15)
> additional comments:
> - please update release for each iteration, it hard to track the changes
> made if it's kept the same and spec and srpms are overridden

I did it => release 2 for rpm below

> - you can drop also the "build" dir for man pages, it's a no-op at the end
> mkdir -p build/man3
> cp man3/*.3 build/man3

not done as detailed in comment #16

> - I would use only VERS_LIB=%{version} otherwise it appends also ".1.fc24"
> which is not correct IMO

I did it

> - the libcxl.so symlink need to be created manually or the makefile be
> updated to create it, then "%files" should have
> %{_libdir}/libcxl.so.*
> and "%files devel" then
> %{_libdir}/libcxl.so

not done as per question in comment #16


Spec URL: https://michelmno.fedorapeople.org/libcxl.spec
SRPM URL: https://michelmno.fedorapeople.org/libcxl-1.3-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component