[Bug 1305496] Review Request: HdrHistogram - A High Dynamic Range Histogram

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1305496

jiri vanek <jvanek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |trepik at redhat.com
              Flags|                            |needinfo?(trepik at redhat.com
                   |                            |)



--- Comment #11 from jiri vanek <jvanek at redhat.com> ---
Thanx!
It looks good.
Just for curiosity - heve you seen your generated
/usr/bin/HistogramLogProcessor ?-)

>From my side the package is ok.
Before initial push I would recommend you to reset release to 1.

One note for future - its quite good to publish the spec/srpm in versioned way.
Somthing like:
Spec URL: https://trepik.fedorapeople.org/v1/HdrHistogram.spec
SRPM URL: https://trepik.fedorapeople.org/v1/HdrHistogram-2.1.8-1.fc23.src.rpm
later
Spec URL: https://trepik.fedorapeople.org/v2/HdrHistogram.spec
SRPM URL: https://trepik.fedorapeople.org/v2/HdrHistogram-2.1.8-2.fc23.src.rpm
...
Spec URL: https://trepik.fedorapeople.org/vN/HdrHistogram.spec
SRPM URL: https://trepik.fedorapeople.org/vN/HdrHistogram-2.1.8-N.fc23.src.rpm

By so, the reviwer can easily diff what you had modified in spec/srpm

And of course reset the release at the end...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component