[Bug 1315020] Review Request: python-nmrglue - Python module for processing NMR data

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1315020

Mukundan Ragavan <nonamedotc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #8 from Mukundan Ragavan <nonamedotc at gmail.com> ---

> 
> Summary: 
> 1) Fix source URL

Fixed.

> 2) Add %check

Done.

> 3) Don't bundle tests

Done.

> 4) Encourage upstream to put license headers at top of files
> 
> [x]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "Unknown or generated". 33 files have unknown license. Detailed
>      output of licensecheck in /home/jgu/Fedora/1315020-python-
>      nmrglue/licensecheck.txt
> 
> Would be nice if upstream added license headers to these files - it's
> worth asking, but this isn't a review blocker.
> 

I will communicate with upstream about license headers.

> [!]: %check is present and all tests pass.
> 
> At the very least you should have a %check section which runs python
> and loads the modules from the buildroot (i.e. not from the sources) -
> check other python packages for examples of this.
> 
> Also I note that the fileio has included tests - these could be run
> during %check.
> 
> And actually, you probably don't want to be packaging the tests.
> 


Fixed.


Relevant sections of the spec file - 

1/ Not installing tests - 

# disable tests bundling
sed -i '/nmrglue.fileio.tests/d' setup.py
sed -i '/package_data/d' setup.py
sed -i '/fileio\/tests\/data\//d' setup.py


2/ run tests

pushd nmrglue/fileio/tests

# python2 tests
PYTHONPATH="%{buildroot}%{python2_sitelib}" %{__python2} test_pipe.py

#python3 tests
PYTHONPATH="%{buildroot}%{python3_sitelib}" %{__python3} test_pipe.py

popd



> python-nmrglue.src: W: invalid-url Source0:
> https://github.com/jjhelmus/nmrglue/releases/download/v0.5/nmrglue-0.5.tar.
> gz HTTP Error 403: Forbidden
> 3 packages and 0 specfiles checked; 0 errors, 10 warnings.
> 
> -----> Check the source URL and fix.
> 
> https://fedoraproject.org/wiki/Packaging:SourceURL
> 

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component