[Bug 1306945] Review Request: ohc - Java large off heap cache

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 15 19:20:14 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1306945



--- Comment #9 from jiri vanek <jvanek at redhat.com> ---
Originally I did not wont you to do so, but when you have asked I get tempted
and take second look.

The batch-bench really looks like useful binary.  General rule for such a
script is to rewrote them, but this one does not looks like best candidate to
it.
Look to the generated launcher from your first package (The hystogram) and you
can find that only think you need to replace in this huge script is generation
of classpath and how java is found and launched. Long story short - sed on two
lines if it goes well.

Second script looks like small tool. So it looks like it can be installed as it
is.

Also I would recommand to add prefix to them - ohc-batch... and
ohc-consolidat...

Feel free to take this as advance and exercise. Not an must.  (but after you
forced me to do second reading of those two scripts it would be nice to have
them :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list